wokring on #1282 "remove ereg". need advice
-
Alexey Zakhlestine
wokring on #1282 "remove ereg". need advice
Thu March 18 2010 11:50:09 UTChttp://trac.midgard-project.org/ticket/1282
Hi.
I was removing ereg*() functions from midcom today.
It's mostly done, except:
* com.affronter.iplocation/lib/maxmind/geoip.php
This is part of external library.
Actually, it is available via pear as http://pear.php.net/package/Net_GeoIP/
Should we just use pear-version and file ereg as an upstream bug (in case it is still used there)
* com.magnettechnologies.contactgrabber/lib/*
Again, this is an external library, as far as I understand
What should we do? Update? File bug upstream? Fork?
* net.nemein.bannedwords/handler.php
Does anyone actually use this? Eero told me, that we should probably just remove this component
If this one is used I will fix it
* org.routamc.photostream/phpFlickr.php
External library http://phpflickr.com/
We use outdated version, but new version still uses ereg() to parse xml.
Update + file bug upstream?
_______________________________________________
dev mailing list
dev@lists.midgard-project.org
http://lists.midgard-project.org/mailman/listinfo/dev -
-
Re: [midgard-dev] wokring on #1282 "remove ereg". need advice
Thu March 18 2010 12:55:06 UTC-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
Alexey Zakhlestin wrote:
> http://trac.midgard-project.org/ticket/1282
>
> * com.affronter.iplocation/lib/maxmind/geoip.php
> This is part of external library.
> Actually, it is available via pear as http://pear.php.net/package/Net_GeoIP/
> Should we just use pear-version and file ereg as an upstream bug (in case it is still used there)
>
Definitely should use the PEAR version unless there are *really* strong
reasons (ie. we need to fork it or something) to use local one.
Filing upstream bug is a good idea, maybe even give them a patch :)
> * com.magnettechnologies.contactgrabber/lib/*
> Again, this is an external library, as far as I understand
> What should we do? Update? File bug upstream? Fork?
>
Im pretty sure this was also done for the infamous Leet project so if
no-one is actually using it we should just drop the component (like with
bannedwords). If it's used update to latest version and file bugs upstream.
>
> * org.routamc.photostream/phpFlickr.php
> External library http://phpflickr.com/
> We use outdated version, but new version still uses ereg() to parse xml.
> Update + file bug upstream?
>
Yep.
As for upstream bugs, if they get ignored I guess we have to fork.
/Rambo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iD8DBQFLoiD6k2FlZlXdE74RA/alAJ9hbgZ78ZVzcoq6ybcu3Cnaf2OOmACeNCg3
BL3EFq2Jm5iJEi8MH5swsio=
=Ng8H
-----END PGP SIGNATURE-----
_______________________________________________
dev mailing list
dev@lists.midgard-project.org
http://lists.midgard-project.org/mailman/listinfo/dev -
-
Re: [midgard-dev] wokring on #1282 "remove ereg". need advice
Wed March 24 2010 14:25:07 UTCHi,
On Thu, Mar 18, 2010 at 1:43 PM, Alexey Zakhlestin <indeyets@gmail.com> wrote:
> * com.affronter.iplocation/lib/maxmind/geoip.php
> This is part of external library.
> Actually, it is available via pear as http://pear.php.net/package/Net_GeoIP/
> Should we just use pear-version and file ereg as an upstream bug (in case it is still used there)
Sounds like a sensible plan. If something is available in PEAR then no
sense in bundling the same code.
> * com.magnettechnologies.contactgrabber/lib/*
> Again, this is an external library, as far as I understand
> What should we do? Update? File bug upstream? Fork?
Just kill the component, this is unmaintained legacy stuff.
> * net.nemein.bannedwords/handler.php
> Does anyone actually use this? Eero told me, that we should probably just remove this
> component
Just kill the component, this is unmaintained legacy stuff.
> * org.routamc.photostream/phpFlickr.php
> External library http://phpflickr.com/
> We use outdated version, but new version still uses ereg() to parse xml.
> Update + file bug upstream?
Yep.
And I guess the Flickr import feature could be disabled if using PHP
5.3 until the library is fixed.
--
Henri Bergius
Motorcycle Adventures and Free Software
http://bergie.iki.fi/
Skype: henribergius
Jabber: henri.bergius@gmail.com
Microblog: http://www.qaiku.com/home/bergie/
My Royal Enfield Bullet 500 is for sale, see http://www.nettimoto.com/844397
_______________________________________________
dev mailing list
dev@lists.midgard-project.org
http://lists.midgard-project.org/mailman/listinfo/dev -
