Open Source Content Management Framework

Re: [midgard-dev] [midgard-commits] r22651 - trunk/midgard/apis/php5

  1. Re: [midgard-dev] [midgard-commits] r22651 - trunk/midgard/apis/php5

    Tue June 23 2009 06:15:09 UTC
    apis/php5 is not buildable again (php_midgard_storage.c is missing)

    On Mon, Jun 22, 2009 at 11:43 PM,
    piotras<midgard-commits@lists.midgard-project.org> wrote:
    > Author: piotras
    > Date: Mon Jun 22 21:43:36 2009
    > New Revision: 22651
    > URL: http://trac.midgard-project.org/changeset/22651
    >
    > Log:
    > Added midgard_storage class. Refs #1136
    >
    >
    > Modified:
    >   trunk/midgard/apis/php5/config.m4
    >   trunk/midgard/apis/php5/midgard.c
    >   trunk/midgard/apis/php5/php_midgard.h
    >   trunk/midgard/apis/php5/php_midgard_connection.c
    >
    > Modified: trunk/midgard/apis/php5/config.m4
    > ==============================================================================
    > --- trunk/midgard/apis/php5/config.m4   (original)
    > +++ trunk/midgard/apis/php5/config.m4   Mon Jun 22 21:43:36 2009
    > @@ -79,4 +79,4 @@
    >
    >  AC_DEFINE(HAVE_MIDGARD, 1, [ ])
    >  PHP_SUBST(MIDGARD2_SHARED_LIBADD)
    > -PHP_NEW_EXTENSION(midgard2, midgard.c preparser.c query_builder.c php_midgard_reflection_property.c php_midgard_collector.c php_midgard_object_parameter.c php_midgard_object_attachment.c php_midgard_config.c php_midgard_gobject_generic.c php_midgard_user.c php_midgard_blob.c php_midgard_sitegroup.c php_midgard_object_class.c php_midgard_compat.c php_midgard_request_config.c php_midgard_connection.c php_midgard_object.c php_midgard_replicator.c php_midgard_dbus.c php_midgard_timestamp.c php_midgard_error.c php_midgard_handle.c php_midgard_transaction.c php_midgard__helpers.c php_midgard_view.c, $ext_shared)
    > +PHP_NEW_EXTENSION(midgard2, midgard.c preparser.c query_builder.c php_midgard_reflection_property.c php_midgard_collector.c php_midgard_object_parameter.c php_midgard_object_attachment.c php_midgard_config.c php_midgard_gobject_generic.c php_midgard_user.c php_midgard_blob.c php_midgard_sitegroup.c php_midgard_object_class.c php_midgard_compat.c php_midgard_request_config.c php_midgard_connection.c php_midgard_object.c php_midgard_replicator.c php_midgard_dbus.c php_midgard_timestamp.c php_midgard_error.c php_midgard_handle.c php_midgard_transaction.c php_midgard__helpers.c php_midgard_view.c php_midgard_storage.c, $ext_shared)
    >
    > Modified: trunk/midgard/apis/php5/midgard.c
    > ==============================================================================
    > --- trunk/midgard/apis/php5/midgard.c   (original)
    > +++ trunk/midgard/apis/php5/midgard.c   Mon Jun 22 21:43:36 2009
    > @@ -420,6 +420,7 @@
    >        php_midgard_error_init(module_number);
    >        php_midgard_transaction_init(module_number);
    >        php_midgard_view_init(module_number);
    > +       php_midgard_storage_init(module_number);
    >
    >        /* Register midgard_metadata class */
    >        static zend_class_entry midgard_metadata_class_entry;
    >
    > Modified: trunk/midgard/apis/php5/php_midgard.h
    > ==============================================================================
    > --- trunk/midgard/apis/php5/php_midgard.h       (original)
    > +++ trunk/midgard/apis/php5/php_midgard.h       Mon Jun 22 21:43:36 2009
    > @@ -206,6 +206,7 @@
    >  void php_midgard_error_init(int module_number);
    >  void php_midgard_transaction_init(int module_number);
    >  void php_midgard_view_init(int module_number);
    > +void php_midgard_storage_init(int module_number);
    >
    >  zend_class_entry *php_midgard_get_baseclass_ptr(zend_class_entry *ce);
    >  zend_class_entry *php_midgard_get_baseclass_ptr_by_name(const gchar *name);
    >
    > Modified: trunk/midgard/apis/php5/php_midgard_connection.c
    > ==============================================================================
    > --- trunk/midgard/apis/php5/php_midgard_connection.c    (original)
    > +++ trunk/midgard/apis/php5/php_midgard_connection.c    Mon Jun 22 21:43:36 2009
    > @@ -43,7 +43,7 @@
    >
    >        if (cnc == NULL)
    >                php_error(E_ERROR, "MidgardConnection underlying GObject is NULL");
    > -
    > +
    >        return cnc;
    >  }
    >
    > _______________________________________________
    > midgard-commits mailing list
    > midgard-commits@lists.midgard-project.org
    > http://lists.midgard-project.org/mailman/listinfo/midgard-commits
    >



    --
    Alexey Zakhlestin
    http://www.milkfarmsoft.com/
    _______________________________________________
    dev mailing list
    dev@lists.midgard-project.org
    http://lists.midgard-project.org/mailman/listinfo/dev
    •  Reply
  2. Re: [midgard-dev] [midgard-commits] r22651 - trunk/midgard/apis/php5

    Tue June 23 2009 08:05:06 UTC
    Alexey Zakhlestin writes:
    > apis/php5 is not buildable again (php_midgard_storage.c is missing)

    Argh... Thanks! Just added this file.
    Sometimes I *do* miss CVS.

    Piotras


    _______________________________________________
    dev mailing list
    dev@lists.midgard-project.org
    http://lists.midgard-project.org/mailman/listinfo/dev
    •  Reply
  3. Re: [midgard-dev] [midgard-commits] r22651 - trunk/midgard/apis/php5

    Tue June 23 2009 09:20:06 UTC
    On Tue, Jun 23, 2009 at 11:53 AM, Piotr Pokora<piotrek.pokora@gmail.com> wrote:
    > Alexey Zakhlestin writes:
    >> apis/php5 is not buildable again (php_midgard_storage.c is missing)
    >
    > Argh... Thanks! Just added this file.
    > Sometimes I *do* miss CVS.

    Well, I have a habit of carefully reading diffs before commiting. It helps ;)


    --
    Alexey Zakhlestin
    http://www.milkfarmsoft.com/
    _______________________________________________
    dev mailing list
    dev@lists.midgard-project.org
    http://lists.midgard-project.org/mailman/listinfo/dev
    •  Reply
  4. Re: [midgard-dev] [midgard-commits] r22651 - trunk/midgard/apis/php5

    Tue June 23 2009 09:25:06 UTC
    Alexey Zakhlestin writes:

    Hi!

    > On Tue, Jun 23, 2009 at 11:53 AM, Piotr Pokora<piotrek.pokora@gmail.com> wrote:
    >> Alexey Zakhlestin writes:
    >>> apis/php5 is not buildable again (php_midgard_storage.c is missing)
    >> Argh... Thanks! Just added this file.
    >> Sometimes I *do* miss CVS.
    >
    > Well, I have a habit of carefully reading diffs before commiting. It helps ;)

    I *do* this before every commit.
    CVS always complained about file not being added. That's why I said I
    miss it :)

    Piotras
    _______________________________________________
    dev mailing list
    dev@lists.midgard-project.org
    http://lists.midgard-project.org/mailman/listinfo/dev
    •  Reply
  5. Re: [midgard-dev] [midgard-commits] r22651 - trunk/midgard/apis/php5

    Tue June 23 2009 10:40:06 UTC
    svn status and svn diff is your friend ... :)

    /Johan "SmallOne" Bernhardsson
    -
    Säkerhet hela vägen ...

    Linux/CMS/Network/Print/Virtualisation/VoIP Consultant

    Phone: +46-13-73244
    Mobile: +46-705-111751
    Fax: +46-13-73190
    Email/Jabber/Sip: johan@anykey.se
    Web: www.anykey.se



    On Tue, 2009-06-23 at 11:14 +0200, Piotr Pokora wrote:
    > Alexey Zakhlestin writes:
    >
    > Hi!
    >
    > > On Tue, Jun 23, 2009 at 11:53 AM, Piotr Pokora<piotrek.pokora@gmail.com> wrote:
    > >> Alexey Zakhlestin writes:
    > >>> apis/php5 is not buildable again (php_midgard_storage.c is missing)
    > >> Argh... Thanks! Just added this file.
    > >> Sometimes I *do* miss CVS.
    > >
    > > Well, I have a habit of carefully reading diffs before commiting. It helps ;)
    >
    > I *do* this before every commit.
    > CVS always complained about file not being added. That's why I said I
    > miss it :)
    >
    > Piotras
    > _______________________________________________
    > dev mailing list
    > dev@lists.midgard-project.org
    > http://lists.midgard-project.org/mailman/listinfo/dev
    >

    _______________________________________________
    dev mailing list
    dev@lists.midgard-project.org
    http://lists.midgard-project.org/mailman/listinfo/dev
    •  Reply
Designed by Nemein, hosted by Kafit